-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Joystick Support #12
Comments
Potential solutionTo implement joystick support, we will create a new Python script How to implement
|
Hi, that sounds awesome! |
Hi @NovoG93, are there still plans to follow up with this? It looks like @winstxnhdw's PR is ready. |
Hi, already merged. |
Tested it! Works great! |
Hey, I am thinking of contributing a PR for joystick support, but I'd like to discuss how we should go about it first.
Would you prefer if it was an entirely new launch file that would launch the teleop joystick node, or should we stick with the current launch file but we pass some sort of flag as an argument?
For example,
ros2 launch sjtu_drone_bringup sjtu_drone_bringup.launch.py joystick
I haven't checked if the
launch
API allows you to pass arguments to the launch file, but I reckon it's likely possible.The text was updated successfully, but these errors were encountered: