Skip to content

Commit

Permalink
simplify isReviewed()
Browse files Browse the repository at this point in the history
  • Loading branch information
NovemLinguae committed Oct 26, 2023
1 parent 78b85b5 commit 89b850b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 28 deletions.
25 changes: 10 additions & 15 deletions DetectG4G5.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,19 @@ class DetectG4G5 {
$('#contentSub').before(`<div class="DetectG4G5" style="background-color: red">${html}</div>`);
}

/**
* @param {number} pageID The page ID number. A positive number with no commas.
*/
async isReviewed(pageID) {
let api = new mw.Api();
let response = await api.get( {
action: 'pagetriagelist',
action: 'query',
format: 'json',
page_id: pageID,
formatversion: '2',
prop: 'isreviewed',
pageids: pageID,
} );

// no result
if ( response.pagetriagelist.result !== 'success' || response.pagetriagelist.pages.length === 0 ) {
return true;
// 1, 2, or 3
} else if ( parseInt(response.pagetriagelist.pages[0].patrol_status) > 0 ) {
return true;
// 0
} else {
return false;
}
return response.query.pages[0].isreviewed;
}

async afdExists(title) {
Expand Down Expand Up @@ -144,7 +139,7 @@ class DetectG4G5 {
shouldRunOnThisPage() {
// don't run when not viewing articles
let action = mw.config.get('wgAction');
if ( action != 'view' ) return false;
if ( action !== 'view' ) return false;

// don't run when viewing diffs
let isDiff = mw.config.get('wgDiffNewId');
Expand All @@ -156,7 +151,7 @@ class DetectG4G5 {
// Only run in mainspace
let namespace = mw.config.get('wgNamespaceNumber');
let title = mw.config.get('wgPageName'); // includes namespace, underscores instead of spaces
if ( namespace !== 0 && title != 'User:Novem_Linguae/sandbox' ) return false;
if ( namespace !== 0 && title !== 'User:Novem_Linguae/sandbox' ) return false;

return true;
}
Expand Down
21 changes: 8 additions & 13 deletions DetectSNG.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,24 +170,19 @@ class DetectSNG {
return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); // $& means the whole matched string
}

/**
* @param {number} pageID The page ID number. A positive number with no commas.
*/
async isReviewed(pageID) {
let api = new mw.Api();
let response = await api.get( {
action: 'pagetriagelist',
action: 'query',
format: 'json',
page_id: pageID,
formatversion: '2',
prop: 'isreviewed',
pageids: pageID,
} );

// no result
if ( response.pagetriagelist.result !== 'success' || response.pagetriagelist.pages.length === 0 ) {
return true;
// 1, 2, or 3
} else if ( parseInt(response.pagetriagelist.pages[0].patrol_status) > 0 ) {
return true;
// 0
} else {
return false;
}
return response.query.pages[0].isreviewed;
}

getWordString() {
Expand Down
3 changes: 3 additions & 0 deletions ReviewStatus.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ class ReviewStatus {
}
}

/**
* @param {number} pageID The page ID number. A positive number with no commas.
*/
async isReviewed(pageID) {
let api = new mw.Api();
let response = await api.get( {
Expand Down

0 comments on commit 89b850b

Please sign in to comment.