Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parse limits to iframely parsing with a default of 3 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julianlam
Copy link
Contributor

It is possible to cause a NodeBB to lock up due to CPU resource exhaustion if you pass in a raw post with hundreds (maybe thousands) of links.

This change limits it to a default of 3, with ACP adjustable value.

@julianlam julianlam requested a review from nleush November 8, 2017 18:26
@julianlam julianlam self-assigned this Nov 8, 2017
@barisusakli
Copy link
Contributor

LGTM, this should be added against stuff like
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants