Tessa/minimal tab suggestions #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should rename the component to TabsMinimal so they're grouped in various alphabetical situations? |
|
Oh dang! I love that idea! 😍 (Will leave to @ap-nri to actually implement though, if he's on board with the change) |
|
I'd also like to do this #1330 for TabsMinimal as well (except 15px based on Ravi's design) so we have that standardized off the bat. |
|
yes and yes and yes I love all of these you are strong and wise collaborators tysm @bendansby and @tesk9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for #1412 and the minimalist tab example on the component catalog.
Mostly, I want the example to be more minimal! So I've cut out the Panel pangrams and made the
tabHtmlexample more closely matched to the intended use oftabHtml.I've also fixed some of the spacing in the example code by using
Codehelpers (I know the Tabs component that we started out copying doesn't provide great examples -- sorry about that!After