Fix ordering of script argument interpolation
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhahn
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
😬
You know what, I swear I thought about this myself when reviewing the last PR and somehow convinced myself that it was working.
FWIW, I usually would use names like revKeys or revArguments for these kinds of folds to remind myself to reverse at the end. I've also had thoughts about making a separate RevList type that you can only concat to and would reverse on converting to a List.
Omg. Brilliant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a
foldlthat builds up a list of keys and literals fornri-redis'scriptquasi quote, and forgot to unrevert the lists 🤦This PR fixes it.