Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strace: set enableParallelBuilding = true #345436

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

phip1611
Copy link
Contributor

Description of changes

Set enableParallelBuilding = true for strace. This reduces the build time from 55s to 25s on my modern 16-core machine.

The main motivation for this step is that I apply a custom patch onto strace in my NixOS configuration and the build time is longer than necessary. The debian package definition shows that strace can be reliably build using multiple makefile jobs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reduces the build time from 55s to 25s on my modern 16-core machine.

The main motivation for this step is that I apply a custom patch onto
strace in my NixOS configuration and the build time is longer than necessary.
The debian package definition shows [0] that strace can be reliably build using
multiple makefile jobs.

[0] strace/strace@0c56f62
@ofborg ofborg bot requested review from Ma27, globin and alyssais September 30, 2024 07:22
@alyssais alyssais added the backport release-24.05 Backport PR automatically label Sep 30, 2024
@alyssais alyssais merged commit dfcde71 into NixOS:master Sep 30, 2024
29 of 30 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants