Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: backport PHP stuff #345177

Closed
wants to merge 6 commits into from
Closed

wip: backport PHP stuff #345177

wants to merge 6 commits into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Sep 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

reckenrode and others added 6 commits September 28, 2024 22:08
@reckenrode @drupol
php{82,83}Extensions.dom: apply upstream patch for libxml2 2.13 compa…
9aeb246 
…tibility
@reckenrode @drupol
php{83,83}Extensions.simplexml: apply upstream patch for libxml2 2.13…
cb7f447 
… compatibility
@reckenrode @drupol
php{83,83}Extensions.soap: apply upstream patch for libxml2 2.13 comp…
69f5c4b 
…atibility
@reckenrode @drupol
php{83,83}Extensions.xml: apply upstream patch for libxml2 2.13 compa…
6623ccd 
…tibility
@reckenrode @drupol
php{83,83}Extensions.xmlwriter: apply upstream patch for libxml2 2.13…
dbf91bd 
… compatibility
@vcunat @drupol
phpExtensions.soap: back to doCheck = false (except on Darwin)
0ee9baf 
On *-linux we get:
> FAILED TEST SUMMARY
> ---------------------------------------------------------------------
> SOAP Bug NixOS#71610 - Type Confusion Vulnerability - SOAP / make_http_soap_request() [tests/bug71610.phpt]
> Bug NixOS#76348 (WSDL_CACHE_MEMORY causes Segmentation fault) [tests/bugs/bug76348.phpt]
Logs e.g.: https://github.com/NixOS/nixpkgs/pull/330299/checks?check_run_id=27989364591
@drupol
Copy link
Contributor Author

drupol commented Sep 28, 2024

@ofborg build php81 php82 php83

@drupol drupol mentioned this pull request Sep 28, 2024
Merged
13 tasks
@Ma27
Copy link
Member

Ma27 commented Sep 29, 2024

@drupol I think we can close this, correct?

@drupol
Copy link
Contributor Author

drupol commented Sep 29, 2024

yup!

@drupol drupol closed this Sep 29, 2024
@drupol drupol deleted the push-yyqzrxtzswxl branch September 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patka-123 patka-123 Awaiting requested review from patka-123

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar will be requested when the pull request is marked ready for review jtojnar is a code owner

@globin globin Awaiting requested review from globin globin will be requested when the pull request is marked ready for review globin is a code owner

Assignees
No one assigned
Labels
6.topic: php 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drupol @Ma27 @reckenrode @vcunat