wayshot 1.3.0 -> 1.3.1

[id3v1669]

Description of changes

https://github.com/waycrate/wayshot/releases/tag/1.3.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Notes

Release version of package has faulty tests with cargo test but runs as intended, so doCheck = false; was added.

---

Add a 👍 reaction to pull requests you find important.

[CyberShadow]

Is there an upstream bug report?

[id3v1669]

Did not find any report in source related to this issue.
In developers makefile they do not run cargo test, just cargo build. So ignoring checks should not be an issue as they passed it to thier release version.

[CyberShadow]

The upstream developers may appreciate a bug report about this, then.

It would also give us something to link to, so that we know what to do about disabling tests in the future. (E.g. if upstream fixes it, we can remove it; if upstream decides they don't care about tests, we will now know that.)

[id3v1669]

Opened issue. What about pull request to nixpkgs? Should just wait for the upstream developers' response to the issue or do something else?

[CyberShadow]

What about pull request to nixpkgs? Should just wait for the upstream developers' response to the issue or do something else?

No need to wait, just add a link to the issue in a comment, that explains why tests are disabled.

[id3v1669]

Tests are disabled for now due to fail of cargo test, will be fixed after pr #114 gets approved.
Issue: #113

[SuperSandro2000]

We can fetchpatch the fix

[id3v1669]

We can fetchpatch the fix

If you mean fetchpatch from commit. That won't be an option as commit has more fixes than version 1.3.1 needs.
Local patch can be created, but is it necessary just for one version?

[teto]

Result of nixpkgs-review pr 302017 run on x86_64-linux 1

1 package failed to build:

• wayshot

[id3v1669]

Result of nixpkgs-review pr 302017 run on x86_64-linux 1

1 package built:

• wayshot

[id3v1669]

Result of nixpkgs-review pr 302017 run on x86_64-linux 1
1 package failed to build:

* wayshot

Just ran nixpkgs-review pr --post-result 302017, no issues.
Any ideas why that might happen?

[teto]

@ofborg build wayshot

[id3v1669]

@ofborg build wayshot

Looks like now it shows different cargoHash from what was before. Please try again, I've changed to the one from ofborg logs.

[id3v1669]

@ofborg build wayshot

[Ma27]

Package looks good functionality-wise.

Please squash your commits together into the following two chunks:

• maintainers: add id3v1669
• wayshot: 1.3.0 -> 1.3.1

Also, you can pass arguments to cargo test via checkFlags = [ ... ];. Maybe that can be used to skip only the tests that are actually broken?

[id3v1669]

Package looks good functionality-wise.

Please squash your commits together into the following two chunks:

* `maintainers: add id3v1669`

* `wayshot: 1.3.0 -> 1.3.1`

Also, you can pass arguments to cargo test via checkFlags = [ ... ];. Maybe that can be used to skip only the tests that are actually broken?

Done.
Regarding testing, I would agree with you if developers actually used some of those tests, but right now, they are irrelevant for this release.
Check please this message, pr for integration testing is still WIP.

done