-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manim: remove old manim(lib) package and init at 0.15.2 #120479
Conversation
bcb78b2
to
39d0514
Compare
This comment has been minimized.
This comment has been minimized.
07863e5
to
4ccdcdb
Compare
Unfortunately cc @c0deaddict |
11f291e
to
da93667
Compare
should be fixed if #121439 gets merged |
Alrighty. I have now added a commit, which removes old |
I didn't realize the old package was called |
Aha! Alright, changed the commit. Now the old |
Existing manim package has been incorrectly named manim, although on PyPi it is called manimlib. It is now developed under the name manimgl, so the PyPi package manimlib will receive no further updates. The new manim package in nixpkgs is now the Manim Community Edition.
There still is the issue remaining that you cannot run
On the other hand it runs happily when you build it normally... i don't understand how the first error message comes from python3.10 but the latter one from python3.9. Could it be possible that it is a problem that we have both python3.10 and python3.9 versions of Packages available and they somehow get mixed up? also checked the wrapped "binaries" in |
I think you're right, the nixpkgs-review shell has both Python 3.9 and 3.10 and that causes problems. #150972 (comment) provides a good description of the problem. You can test the manim binary by passing |
i guess you mean passing |
Sorry, I should have typed the complete command! I meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most commit messages need to be prefixed with python3Packages.
.
The first and last commits should be squashed together.
Isosurfaces needs to set doCheck = false
with a comment that upstream has no tests.
It was my suggestion to not squash the first and last commits. I don't really care either way, though; whatever gets this merged faster is fine by me. |
Fine with me if it was a concious decision 👍 |
so... i committed all suggestions. about now at least partially enabled tests for manim: there might be still work to do if we want to get all tests running. especially most failing tests need display. I tried to do it with |
Result of 9 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to not have all tests work for now. Let's hope some day someone comes up with a way to fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 184 comments this is well looked at. Now get it out there and we find the remaining bugs there.
Woohoo! Finally, it is merged 🥳 🥳 🥳 Thanks to everyone who helped me with your comments & patience! I think i learned quite a bit about nix packaging :) |
Motivation for this change
There is an existing python application called
manim
in nixpkgs, but, it is first of all incorrectly named (on PyPi it is called manimlib) and it's development under this name is discontinued. The originalmanim
-package was created and is still being developed by the author of the Youtube-math-channel 3blue1brown under the new namemanimgl
. The version I packaged here is a community-developed fork, which is supposed to be more stable and clean. It brings along 4 dependenciesmapbox-earcut
,cloup
,isosurfaces
andsrt
.In order to make this package the new
manim
package in nixpkgs, i did remove the old manim(lib) package in favor of the new one.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)