Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 6.4.0 of the Validator and QA tooling, and adjust … #471

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/qa-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
with:
fetch-depth: 0
- name: Zib2020 QA
uses: Nictiz/Nictiz-tooling-R4-QA@6.3.0
uses: Nictiz/Nictiz-tooling-R4-QA@6.4.0
with:
changed-only: false
verbosity-level: warning
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-changed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
with:
fetch-depth: 0
- name: Zib2020 QA
uses: Nictiz/Nictiz-tooling-R4-QA@6.3.0
uses: Nictiz/Nictiz-tooling-R4-QA@6.4.0
with:
changed-only: true
extensible-binding-warnings: true
Expand Down
62 changes: 22 additions & 40 deletions known-issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -826,26 +826,32 @@ issues should occur: false
- message: Unable to validate code without using server
reason: This warning doesn't provide any feedback on the correctness of the materials. In addition, there's little reason to fix this issue on the package level as it is unlikely that this ever results in problems in production (CodeSystems are not typically validated in production).

2.16.840.1.113883.2.4.3.11.60.40.2.5.1.3--20200901000000:
ignored issues:
ValueSet.compose.include[9].filter[0]:
- message: The value for a filter based on property 'concept' must be a valid code from the system 'http://snomed.info/sct', and '31000147101' is not
reason: This code represents the DHD Diagnosethesaurus, which the default terminology server is unable to check

2.16.840.1.113883.2.4.3.11.60.40.2.14.1.2--20200901000000:
ignored issues:
ValueSet.compose.include[0].filter[0]:
- message: The value for a filter based on property 'concept' must be a valid code from the system 'http://snomed.info/sct', and '41000147108' is not
reason: This code represents the DHD Verrichtingenthesaurus, which the default terminology server is unable to check

nl-core-*:
ignored issues:
"*":
- message: No valid Display Names found for
reason: This warning doesn't provide any feedback on the correctness of the materials, but only on the completeness of the terminology server used.
"*.text.div":
- message: "The URL is not valid because '(The mimetype portion of the data: URL is not valid (Mime type invalid) in URL: data:application/octet-stream;base64,"
reason: application/octet-stream is a valid mime type, but the Validator thinks it isn't (at the time of writing).
"*.address*.country.extension[0].value*":
- message: None of the codings provided are in the value set 'LandCodelijsten' (http://decor.nictiz.nl/fhir/ValueSet/2.16.840.1.113883.2.4.3.11.60.121.11.10--20200901000000), and a coding from this value set is required) (codes = urn:oid:2.16.840.1.113883.2.4.4.16.34#6030)
- message: None of the codings provided are in the value set 'LandCodelijsten'
reason: The current version of the Validator incorrectly raises an error on combined ValueSets.
"*.code":
- message: None of the codings provided are in the value set 'VerrichtingTypeCodelijsten'
reason: The current version of the Validator incorrectly raises an error on combined ValueSets.
"*.telecom[*].system.extension[*].value.ofType(CodeableConcept).coding[*]":
- message: Wrong Display Name 'Mobile Phone' for http://terminology.hl7.org/CodeSystem/v3-AddressUse#MC
reason: This core display value is redefined by the ValueSet, but this isn't properly recognized by the Validator
"*.contentType":
- message: The value provided ('application/octet-stream') is not in the value set 'MimeType'
reason: The Validator is unable to check mime types in absence of a terminology server.
Condition.code:
- message: None of the codings provided are in the value set 'ProbleemNaamCodelijst'
reason: This ValueSet contains two SNOMED refsets. The terminology servers are unable to determine if a code is part of this refset.
Expand All @@ -857,6 +863,9 @@ nl-core-*:
Observation.hasMember[*]:
- message: This element does not match any known slice defined in the profile
reason: The Validator is unable to resolve references on disk, so it is unable to match reference slices
Procedure.code:
- message: "Error from http://tx.fhir.org/r4: The Snomed Concept 41000147108 was not known"
reason: This code represents the DHD Verrichtingenthesaurus, which the default terminology server is unable to check. This causes problems on some occasions (but not all).

nl-core-AllergyIntolerance*:
ignored issues:
Expand Down Expand Up @@ -908,24 +917,18 @@ nl-core-HearingFunction.HearingAid-*:
- message: 'Profile http://nictiz.nl/fhir/StructureDefinition/nl-core-HearingFunction.HearingAid, Element matches more than one slice'
reason: The Validator cannot actually inspect the referenced resources, and falsely assumes the reference is a reference to the offending profile.

nl-core-HeartRate-*:
ignored issues:
Observation.component[*].value.*:
- message: None of the codings provided are in the value set 'Vital Signs Units'
reason: The Validator checks all Observations with a vital signs magic LOINC code against the HL7 Vital Signs base profile. Unfortunately, this profile restricts the allowed components to only the use cases identified by HL7, while the zib adds additional data. This has been identified as a bug in het HL7 Vital Signs profile, which will be fixed in the next version. See https://jira.hl7.org/browse/FHIR-43353 for more information.

nl-core-Burnwound.Extent-*:
ignored issues:
Observation.code.coding[*].code:
- message: Unknown code '360531000146101' in the CodeSystem 'http://snomed.info/sct'
reason: This Dutch code is not yet known in the default terminology server

nl-core-VisualFunction.VisualAid-*:
ignored issues:
DeviceUseStatement.reasonReference[*]:
- message: 'Profile http://nictiz.nl/fhir/StructureDefinition/nl-core-VisualFunction.VisualAid, Element matches more than one slice'
reason: The Validator cannot actually inspect the referenced resources, and falsely assumes the reference is a reference to the offending profile.

nl-core-LaboratoryTestResult-*:
ignored issues:
Observation.code:
- message: None of the codings provided are in the value set 'TestCode-en-Onderzoek-Codelijsten'
reason: The current version of the Validator incorrectly raises an error on combined ValueSets.

nl-core-PainScore-01:
ignored issues:
Observation.method:
Expand Down Expand Up @@ -959,15 +962,6 @@ nl-core-PulseRate-*:
Observation.code:
- message: "HeartRateCode: magic LOINC code 8867-4 required, but not found"
reason: The Validator regards a heart rate measured by palpation as a special case of a heart rate and requires the heart rate code to be present in addition, whereas the zib regards a "pulse rate" as something fundamentally different than a heart rate. This issue is tracked in https://nictiz.atlassian.net/browse/ZIB-2216. Until it has been resolved, this error message is silenced.
Observation.component[*].value.*:
- message: None of the codings provided are in the value set 'Vital Signs Units'
reason: The Validator checks all Observations with a vital signs magic LOINC code against the HL7 Vital Signs base profile. Unfortunately, this profile restricts the allowed components to only the use cases identified by HL7, while the zib adds additional data. This has been identified as a bug in het HL7 Vital Signs profile, which will be fixed in the next version. See https://jira.hl7.org/browse/FHIR-43353 for more information.

nl-core-Wound-*-DateOfLastDressingChange-*:
ignored issues:
Observation.code.coding[*].code:
- message: Unknown code '360541000146109' in the CodeSystem 'http://snomed.info/sct'
reason: This Dutch code is not yet known in the default terminology server

zib-*Function.*Aid.Product:
ignored issues:
Expand All @@ -983,12 +977,6 @@ zib-Alert:
- message: "Constraint failed: sd-pg-04: 'If mapping.map exists and the mapping is not implicit, alias should exist.'"
reason: The alias "Alert" is already defined in the base profile, so it doesn't need to be defined again in the differential.

zib-Burnwound.Extent:
ignored issues:
Observation.code:
- message: Unknown code '360531000146101' in the CodeSystem 'http://snomed.info/sct'
reason: This Dutch code is not yet known in the default terminology server

zib-CareTeam:
ignored issues:
CareTeam.participant:*.member:
Expand Down Expand Up @@ -1056,9 +1044,3 @@ zib-Payer-Organization:
reason: The short description is defined on the datatype profile and not repeated in the differential.
- message: "Constraint failed: sd-pg-04: 'If mapping.map exists and the mapping is not implicit, alias should exist.'"
reason: The alias is defined on the datatype profile and not repeated in the differential.

zib-wounds.DateOfLastDressingChange:
ignored issues:
Observation.code:
- message: Unknown code '360541000146109' in the CodeSystem 'http://snomed.info/sct'
reason: This Dutch code is not yet known in the default terminology server
1 change: 0 additions & 1 deletion qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ steps:
- nl-core extensions
- other profiles
- examples
script: check-id.sh
check nl-core overrides:
patterns: nl-core profiles
script: nl-core-overrides.sh
42 changes: 0 additions & 42 deletions util/qa/check-id.py

This file was deleted.

4 changes: 0 additions & 4 deletions util/qa/check-id.sh

This file was deleted.

2 changes: 1 addition & 1 deletion util/qa/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
nictiz-r4-qa:
image: ghcr.io/nictiz/nictiz-tooling-r4-qa:6.3.0
image: ghcr.io/nictiz/nictiz-tooling-r4-qa:6.4.0
container_name: nictiz-r4-qa-zib2020
volumes:
- type: bind
Expand Down
Loading