Bump QA tooling version to 6.3.0, and remove the now obsolete known i…

…ssues
Nictiz · May 16, 2024 · 3dcab39 · 3dcab39
1 parent dcba9e8
commit 3dcab39
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 55 deletions.
diff --git a/.github/workflows/qa-all.yml b/.github/workflows/qa-all.yml
@@ -11,7 +11,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: Zib2020 QA
-        uses: Nictiz/Nictiz-tooling-R4-QA@6.2.13
+        uses: Nictiz/Nictiz-tooling-R4-QA@6.3.0
         with:
           changed-only: false
           verbosity-level: warning

diff --git a/.github/workflows/qa-changed.yml b/.github/workflows/qa-changed.yml
@@ -11,7 +11,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: Zib2020 QA
-        uses: Nictiz/Nictiz-tooling-R4-QA@6.2.13
+        uses: Nictiz/Nictiz-tooling-R4-QA@6.3.0
         with:
           changed-only: true
           extensible-binding-warnings: true

diff --git a/known-issues.yml b/known-issues.yml
@@ -148,10 +148,6 @@ zib-BodyTemperature:
         reason: The slice name "BodyTempCode" is chosen to align with the Vital Signs profile for BodyTemperature.
 
 zib-CareTeam:
-  ignored issues:
-    CareTeam.participant:*.member:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     CareTeam.name:
       - short: CareTeamName instead of CareTeamNaam
@@ -190,13 +186,6 @@ zib-ContactPerson:
     RelatedPerson.telecom: Although there is a cardinality mismatch for the mapping of zib concept ContactPerson.ContactInformation on this element (as pointed out above), the cardinalities between zib and FHIR do match for the mapping of zib concept Payer.ContactInformation (NL-CM:1.1.12), as these are both 0..*.
 
 zib-Encounter:
-  ignored issues:
-    Encounter.participant:healthProfessional.individual:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
-    Encounter.reasonReference:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     Encounter.class:
       - cardinality: 1..1 instead of 0..1
@@ -218,10 +207,6 @@ zib-FLACCpainScale:
         reason: The root of the zib is called "FLACCpainScore" (which is incorrect), even though the zib itself is called "FLACCpainScale".
 
 zib-FreedomRestrictingIntervention:
-  ignored issues:
-    Procedure.reasonReference:legalSituation-*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     Procedure:
       - short: FreedomRestrictingIntervention instead of FreedomrestrictingIntervention
@@ -275,10 +260,6 @@ zib-HealthProfessional-PractitionerRole:
         reason: ContactInformation in FHIR is represented using the ContactPoint datatype, not as a separate resource. Because the FHIR profile for ContactInformation consists of two parts the root concept of ContactInformation is mapped on .telecom.
 
 zib-HearingFunction.HearingAid:
-  ignored issues:
-    DeviceUseStatement.reasonReference:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     DeviceUseStatement:
       - datatype: undefined
@@ -313,18 +294,8 @@ zib-HelpFromOthers:
     CarePlan:
       - message: The slice definition for CarePlan.activity.detail.performer has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended
         reason: This is indeed what is intended, just one of these slices may be chosen.
-    CarePlan.activity.detail.performer:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The slice is constrained on the target profile because this is what defines the slice. The HL7 base references are still available in the default slice. 
 
 zib-LaboratoryTestResult:
-  ignored issues:
-    Observation.performer:performer:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
-    Observation.hasMember:laboratoryTest:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     Observation.status:
       - cardinality: 1..1 instead of 0..1
@@ -367,13 +338,6 @@ zib-LaboratoryTestResult.SpecimenSource:
         reason: The zib concept SpecimenSource is represented using a reference to this profile from zib-LaboratoryTestResult.Specimen, so this element represents just part of the mapping. Overall, the use of this concept is optional, but when this profile is used, Device.deviceName.name must be given.
 
 zib-MedicalDevice:
-  ignored issues:
-    DeviceUseStatement.derivedFrom:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
-    DeviceUseStatement.reasonReference:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     DeviceUseStatement.bodySite:
       - datatype: CodeableConcept instead of a reference
@@ -464,12 +428,6 @@ zib-NursingIntervention:
     CarePlan:
       - message: The slice definition for CarePlan.activity.detail.performer has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended
         reason: This is indeed what is intended, just one of these slices may be chosen.
-    CarePlan.contributor:requester:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The slice is constrained on the target profile because this is what defines the slice. The HL7 base references are still available in the default slice.
-    CarePlan.activity.detail.performer:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The slice is constrained on the target profile because this is what defines the slice. The HL7 base references are still available in the default slice. 
 
 zib-Patient:
   zib deviations:
@@ -571,10 +529,6 @@ zib-Problem:
         reason: The referenced zib AnatomicalLocation is profiled on a datatype level and not a resource. Therefore it cannot be referenced, rather its concepts and constraints are added inline. This element conforms to the zib AnatomicalLocation.
 
 zib-Procedure-event:
-  ignored issues:
-    Procedure.report:textResult:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     Procedure.bodySite:
       - datatype: CodeableConcept instead of a reference
@@ -707,10 +661,6 @@ zib-Vaccination-request:
         reason: ImmunizationRecommendation.recommendation.dateCriterion has cardinality 0..1, making the cardinality of ImmunizationRecommendation.recommendation.dateCriterion.value effectively 0..1 as required by the zib.
 
 zib-VisualFunction.VisualAid:
-  ignored issues:
-    DeviceUseStatement.reasonReference:*:
-      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7  base references.'"
-        reason: The restriction only applies to, and defines, this slice. The slicing is open so the base references can still be used.
   zib deviations:
     DeviceUseStatement:
       - datatype: undefined
@@ -910,7 +860,13 @@ zib-Alert:
     Flag:
       - message: "Constraint failed: sd-pg-04: 'If mapping.map exists and the mapping is not implicit, alias should exist.'"
         reason: The alias "Alert" is already defined in the base profile, so it doesn't need to be defined again in the differential.
-
+
+zib-CareTeam:
+  ignored issues:
+    CareTeam.participant:*.member:
+      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7 base references, unless they are added on a slice"
+        reason: The restriction is set on a slice, but this cannot be automatically checked.
+
 zib-ContactPerson:
   ignored issues:
     RelatedPerson.address:
@@ -919,6 +875,12 @@ zib-ContactPerson:
       - message: "Constraint failed: sd-pg-04: 'If mapping.map exists and the mapping is not implicit, alias should exist.'"
         reason: The alias is defined on the datatype profile and not repeated in the differential.
 
+zib-Encounter:
+  ignored issues:
+    Encounter.participant:healthProfessional.individual:
+      - message: "Constraint failed: sd-zpg-03: 'References to other resource profiles should be added next to the HL7 base references, unless they are added on a slice."
+        reason: The restriction is set on a slice, but this cannot be automatically checked.
+
 zib-HealthcareProvider:
   ignored issues:
     Location.address:

diff --git a/util/qa/docker-compose.yml b/util/qa/docker-compose.yml
@@ -1,7 +1,6 @@
-version: "3.9"
 services:
   nictiz-r4-qa:
-    image: ghcr.io/nictiz/nictiz-tooling-r4-qa:6.2.13
+    image: ghcr.io/nictiz/nictiz-tooling-r4-qa:6.3.0
     container_name: nictiz-r4-qa-zib2020
     volumes:
       - type: bind