This repository has been archived by the owner on May 6, 2024. It is now read-only.
Prepare For Release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fsobolev Code looks good overall, just some minor syntax things I changed. For MPVEvent, I made all the Get() methods into actual get properties to follow C# style Please test and make sure nothing broke :)
@fsobolev For both internal and non-internal make sure everything is full documented (there are some properties and classes missing docs) Also for methods that throw exceptions, please add <exception></exception> tag to describe when the exception will be thrown. I added the tag to some methods, which you can look at for an example.
fsobolev
approved these changes
Jul 18, 2023
fsobolev
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
public object? GetData()
{
return Format switch
{
MPVFormat.String or MPVFormat.OSDString => Marshal.PtrToStringUTF8(_data),
MPVFormat.Flag => Marshal.ReadInt32(_data) == 1,
MPVFormat.Int64 => Marshal.ReadInt64(_data),
MPVFormat.Double => 0.0,
MPVFormat.Node => Marshal.PtrToStructure<MPVNode>(_data),
_ => null
};
}
just noticed I forgot to make conversion to double 😂 Gonna fix this
fsobolev
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.