Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update artist models with osu-web attributes #223

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat: update artist models with osu-web attributes #223

merged 1 commit into from
Feb 20, 2024

Conversation

NiceAesth
Copy link
Owner

@NiceAesth NiceAesth commented Feb 20, 2024 •
edited
Loading

see https://github.com/ppy/osu-web/blob/7ea09d7fbb1c835200915517d22349ac43e7ffea/app/Models/Artist.php

Self-check

  • The changes are tested with pre-commit
  • The changes pass unit testing with pytest
  • The changes pass mypy

@NiceAesth NiceAesth merged commit b84363e into master Feb 20, 2024
4 checks passed
@NiceAesth NiceAesth deleted the artist-models branch February 20, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NiceAesth