Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: mod type testing #181

Merged
merged 2 commits into from
Sep 24, 2023
Merged

tests: mod type testing #181

merged 2 commits into from
Sep 24, 2023

Conversation

NiceAesth
Copy link
Owner

@NiceAesth NiceAesth commented Sep 24, 2023 •
edited
Loading

Self-check

  • The changes are tested with pre-commit
  • The changes pass unit testing with pytest
  • The changes pass mypy

@NiceAesth
tests: add unit test for mod operations
dc67765
@NiceAesth
fix: improve mod operator behaviour
4bfe589 
Changed operators to follow proper implementation (returning `NotImplemented`)
Changed `Mods` to respectively automatically apply DT/SD when NC/PF are specified
@NiceAesth NiceAesth changed the title Mod type testing tests: mod type testing Sep 24, 2023
@NiceAesth NiceAesth merged commit b6de876 into master Sep 24, 2023
4 checks passed
@NiceAesth NiceAesth deleted the mod-type-testing branch September 24, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NiceAesth