Skip to content

Commit

Permalink
fix: typos in models (#164)
Browse files Browse the repository at this point in the history
* Changed: event.py Fixed typo errors in Event(BaseModel) achievement: Optional[Achievement] = None # typo achievment  and in common.py Achievement(BaseModel) description: str # typo desciption

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed: Achievement class parameter mode is a optional Field, possible can be null. Example is the achievement: Autocreation that has a gamemode of null

* chore: remove unrelated changes in .gitignore

* chore: revert unrelated change

* Update .gitignore

* chore: fix pr

* chore: fix pr

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: NiceAesth <[email protected]>
  • Loading branch information
3 people authored Aug 25, 2023
1 parent e68a7b7 commit 41d49bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions aiosu/models/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ class Achievement(BaseModel):
id: int
name: str
slug: str
desciption: str
description: str
grouping: str
icon_url: str
mode: Gamemode
ordering: int
mode: Optional[Gamemode] = None
instructions: Optional[str] = None


Expand Down
2 changes: 1 addition & 1 deletion aiosu/models/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class Event(BaseModel):
type: EventType
r"""Information on types: https://github.com/ppy/osu-web/blob/master/resources/assets/lib/interfaces/event-json.ts"""
parse_error: Optional[bool] = None
achievment: Optional[Achievement] = None
achievement: Optional[Achievement] = None
user: Optional[EventUser] = None
beatmap: Optional[EventBeatmap] = None
beatmapset: Optional[EventBeatmapset] = None
Expand Down

0 comments on commit 41d49bd

Please sign in to comment.