Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip managing Cyberpunk Saves and avoid indexing 60GB of Archive/Pc/Content #2076

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Sep 24, 2024

  • Disabled management of Saves for cyberpunk to avoid accidental save data deletion
  • Avoid indexing 60GB of Archive/Pc/Content folder for CP to speedup management of the game

This can be temporary, but testing the game with collections while having to constantly reset the DB and re-manage the game again is wasting a lot of time at the moment. This should cut down the overhead while not really having any impact to users of the extension at the moment.

@Al12rs Al12rs self-assigned this Sep 24, 2024
@Al12rs Al12rs requested a review from a team September 24, 2024 10:39
@Al12rs Al12rs changed the title Speedup managing Cyberpunk by not indexing 60GB of Archive/Pc/Content Skip managing Cyberpunk Saves and avoid indexing 60GB of Archive/Pc/Content Sep 24, 2024
@Pickysaurus
Copy link
Contributor

Turning off save management lowers the priority of this issue: #2077

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself is fine, but I have no idea of the ramifications of not indexing a file in the current DataStore.

This is probably a bit unsafe; fine for dev builds, risky for release builds.
If you're saying it's fine, I take your word for it.

@Al12rs Al12rs merged commit a6f75e0 into main Sep 25, 2024
11 checks passed
@Al12rs Al12rs deleted the cp2077-ignored-paths branch September 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants