Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Explicitly Set Working Directory for nxm handler on Linux #2057

Closed
wants to merge 3 commits into from

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Sep 18, 2024

For the details, please see:

Putting this PR up so I can get a build; want to know if this fixes the end user issue.
Can still be merged however.


Because this may be brought up. Yes, ideally our App shouldn't break if executed from the wrong working directory in the first place, but that's a topic for another day.

@Sewer56 Sewer56 added the meta-improvement An issue that improves an existing feature label Sep 18, 2024
@Sewer56 Sewer56 self-assigned this Sep 18, 2024
@erri120
Copy link
Member

erri120 commented Sep 18, 2024

I'm not a fan of this, downstream would have to sed yet another key. Do we have logs of the failed attempt to start the app from the home directory? I'd much rather fix that.

@Sewer56
Copy link
Member Author

Sewer56 commented Sep 18, 2024

I'm not a fan of this, downstream would have to sed yet another key. Do we have logs of the failed attempt to start the app from the home directory? I'd much rather fix that.

Me neither, as I mentioned in the opening post. Ideally it shouldn't break in the first place.

Anyway, no, not currently if you look at general channel. I'm waiting for user feedback there. Since wanted to confirm whether incorrect CWD is the issue.

Had some things to get out the way first, so making this build got a bit delayed.

@Sewer56 Sewer56 closed this Sep 18, 2024
@Sewer56
Copy link
Member Author

Sewer56 commented Sep 18, 2024

Closing this because it didn't solve the user end-issue. Turns out they're running AppImage, but our logs said 'Archive'. I'll talk and look into that a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-improvement An issue that improves an existing feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants