Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'electrode_group' col of Units to be ElectrodeGroup type #820

Merged
merged 8 commits into from
Feb 25, 2019

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Feb 18, 2019

Motivation

fix #834

Now electrode groups can be added to the Units table

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #820 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #820   +/-   ##
=======================================
  Coverage   73.72%   73.72%           
=======================================
  Files          60       60           
  Lines        7190     7190           
  Branches     1517     1517           
=======================================
  Hits         5301     5301           
  Misses       1459     1459           
  Partials      430      430
Impacted Files Coverage Δ
src/pynwb/misc.py 86.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9429c9...d403b33. Read the comment docs.

@bendichter
Copy link
Contributor Author

bendichter commented Feb 22, 2019

@ajtritt @oruebel this is part of NeurodataWithoutBorders/nwb-schema#248, but it also is needed on a few other fronts. Was making the electrode_group of type "array" intentional? It seems like it should be ElectrodeGroup.

@bendichter bendichter merged commit 0c1a849 into dev Feb 25, 2019
@rly rly deleted the fix/electrode_group_col branch August 2, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units['electrode_group'] does not accept ElectrodeGroup objects
2 participants