Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grid_spacing and origin_coords to the fields of ImagingPlane #1892

Merged
merged 7 commits into from
May 2, 2024
Merged

Add grid_spacing and origin_coords to the fields of ImagingPlane #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
493b0ff
add grid spacing and origin_coords to fields
h-mayorquin Apr 19, 2024
c2408a5
Update ophys.py
rly Apr 24, 2024
f41a91a
Merge branch 'dev' into add_grid_spacing_to_fields
rly Apr 25, 2024
fe5a849
add changelog
h-mayorquin Apr 25, 2024
fdcd39d
Merge branch 'dev' into add_grid_spacing_to_fields
rly Apr 25, 2024
242cc90
Update CHANGELOG.md
rly Apr 25, 2024
a5aa114
Merge branch 'dev' into add_grid_spacing_to_fields
rly May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Support `stimulus_template` as optional predefined column in `IntracellularStimuliTable`. @stephprince [#1815](https://github.com/NeurodataWithoutBorders/pynwb/pull/1815)
- Support `NWBDataInterface` and `DynamicTable` in `NWBFile.stimulus`. @rly [#1842](https://github.com/NeurodataWithoutBorders/pynwb/pull/1842)
- Added support for python 3.12 and upgraded dependency versions. This also includes infrastructure updates for developers. @mavaylon1 [#1853](https://github.com/NeurodataWithoutBorders/pynwb/pull/1853)
- Added `grid_spacing`, `grid_spacing_unit`, `origin_coords`, `origin_coords_unit` to `ImagingPlane` fields. @h-mayorquin [#1892](https://github.com/NeurodataWithoutBorders/pynwb/pull/1892)
- Added `mock_Units` for generating Units tables. @h-mayorquin [#1875](https://github.com/NeurodataWithoutBorders/pynwb/pull/1875) and [#1883](https://github.com/NeurodataWithoutBorders/pynwb/pull/1883)
- Allow datetimes without a timezone and without a time. @rly [#1886](https://github.com/NeurodataWithoutBorders/pynwb/pull/1886)
- No longer automatically set the timezone to the local timezone when not provided. [#1886](https://github.com/NeurodataWithoutBorders/pynwb/pull/1886)
Expand Down
7 changes: 6 additions & 1 deletion src/pynwb/ophys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ class ImagingPlane(NWBContainer):
'manifold',
'conversion',
'unit',
'reference_frame')
'reference_frame',
'grid_spacing',
'grid_spacing_unit',
'origin_coords',
'origin_coords_unit'
)

@docval(*get_docval(NWBContainer.__init__, 'name'), # required
{'name': 'optical_channel', 'type': (list, OpticalChannel), # required
Expand Down
Loading