Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add waveforms to Units table #448

Merged
merged 10 commits into from
Apr 23, 2021
Merged

add waveforms to Units table #448

merged 10 commits into from
Apr 23, 2021

Conversation

bendichter
Copy link
Contributor

fix #248

@bendichter bendichter requested a review from rly June 1, 2020 20:47
rly
rly reviewed Jun 1, 2020
View reviewed changes
core/nwb.misc.yaml Outdated Show resolved Hide resolved
rly
rly requested changes Jun 1, 2020
View reviewed changes
core/nwb.misc.yaml Show resolved Hide resolved
@bendichter bendichter mentioned this pull request Jun 4, 2020
Merged
5 tasks
@bendichter bendichter requested a review from rly June 9, 2020 22:37
rly
rly previously approved these changes Jun 10, 2020
View reviewed changes
@rly
Copy link
Contributor

rly commented Jun 10, 2020

This looks good to me but let's wait on feedback from at least @oruebel and @ajtritt

@bendichter bendichter requested a review from rly June 17, 2020 16:47
@bendichter
Copy link
Contributor Author

Our current plan is to implement indexes of indexes. @ajtritt 👀

@rly
Copy link
Contributor

rly commented Jun 24, 2020

New suggestion to get around different numbers of electrodes for each waveform:
index of indices.

Requires hdmf to support this and hdmf-common-schema VectorIndex to inherit from VectorData instead of Index.

@rly rly mentioned this pull request Jun 24, 2020
Closed
@rly
Copy link
Contributor

rly commented Jul 30, 2020 •
edited
Loading

TODO:

  • finish and clean up a brief description of how tables, ragged arrays, doubly ragged arrays, and table row references work in NWB
  • add links to the more complete documentation of these types in hdmf-common-schema

@rly rly added this to the NWB 2.4.0 milestone Aug 6, 2020
@rly rly modified the milestones: NWB 2.4.0, NWB 2.3.0 Nov 11, 2020
@bendichter bendichter merged commit a051226 into dev Apr 23, 2021
@rly rly deleted the enh/add_units_waveforms branch August 25, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NWB 2.3.0
Development

Successfully merging this pull request may close these issues.

accessing spike waveforms from units table
2 participants
@bendichter @rly