Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add UnitSeries neurodata_type #245

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Conversation

ajtritt
Copy link
Member

@ajtritt ajtritt commented Jan 17, 2019

This is a proposal/work-in-progress for addressing #194. It adds a new type, called UnitSeries, that would replace Clustering. It extends TimeSeries and requires that TimeSeries.data be an int. It also adds an additional dataset, called units that is a DynamicTableRegion that points to Units table.

@tjd2002
Copy link
Contributor

tjd2002 commented Jan 17, 2019

Would this allow two or more spikes from different units with the same timestamp? (This can happen in real data)

@ajtritt
Copy link
Member Author

ajtritt commented Jan 17, 2019

@tjd2002

Would this allow two or more spikes from different units with the same timestamp? (This can happen in real data)

Yes, there are no restrictions on unique time stamps in TimeSeries

@bendichter
Copy link
Contributor

I'm fine with the name change, and I like that this now inherits from TimeSeries, but it would be nice if there was some kind of link to SpikeEventSeries (#239). As it stands now, if you had multiple UnitSeries and multiple SpikeEventSeries objects (e.g., 6, one for each of 6 shanks), it is unclear how you would indicate which SpikeEventSeries object is connected to which UnitSeries object. I guess you could do it implicitly if both had a field for referencing the regions of the Units table, and you implied that objects that referenced the same Units table region were connected.

ElectrodeGroup -> SpikeEventSeries
SpikeEventSeries -> UnitSeries
UnitSeries -> Units table
@rly rly added this to the NWB 2.2 milestone Aug 28, 2019
@rly rly modified the milestones: NWB 2.2, Future Jun 1, 2020
@rly rly marked this pull request as draft August 5, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants