Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daily failure email list #926

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update daily failure email list #926

merged 1 commit into from
Sep 13, 2024

Conversation

pauladkisson
Copy link
Collaborator

Switches to using the github secret for email notifications of daily tests failing.

@CodyCBakerPhD
Copy link
Collaborator

This is by choice

#920 (comment)

@pauladkisson
Copy link
Collaborator Author

pauladkisson commented Sep 12, 2024

I think with this sheet to keep track of secret owners/locations it shouldn't be tough to debug, and then we wouldn't need a PR to add/remove an email.

What do you think?

@rly
Copy link
Collaborator

rly commented Sep 13, 2024

This is fine to me, though it is not transparent to me who is currently getting emails, so it would be hard to update these secrets. Can I get access to that google sheet? Or we can make a separate one for the NeurodataWithoutBorders repos like nwb-guide and nwbinspector.

@rly
Copy link
Collaborator

rly commented Sep 13, 2024

Add Issue or Pull Request to Dashboard / Add issue or pull request to project (pull_request) is failing. It looks like this adds an issue/PR to the catalystneuro board. Can you update the token for this, or remove it if it is no longer needed?

@pauladkisson
Copy link
Collaborator Author

This is fine to me, though it is not transparent to me who is currently getting emails, so it would be hard to update these secrets. Can I get access to that google sheet? Or we can make a separate one for the NeurodataWithoutBorders repos like nwb-guide and nwbinspector.

Just shared.

@pauladkisson pauladkisson merged commit 7df32c6 into main Sep 13, 2024
24 of 28 checks passed
@pauladkisson pauladkisson deleted the daily_failure_email branch September 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants