Update puppeteer, re-enable mac CI, split e2e CI #910
Conversation
behavior_testing_data
Outdated
There was a problem hiding this comment.
What are these submodules? I can't follow them anywhere
There was a problem hiding this comment.
Oh! That was not intentional.
There was a problem hiding this comment.
That said, did you actually make some GitHub repositories with our example testing data? And maybe git LFS? Because we've all wanted that for a really long time lol
There was a problem hiding this comment.
I guess I accidentally added the testing data git repos as submodules. How would you want these repos/submodules to work?
There was a problem hiding this comment.
I guess I accidentally added the testing data git repos as submodules.
But that's what I'm confused about - there aren't any git repos currently (well, technically git-annex via GIN)
How would you want these repos/submodules to work?
Identically to the GIN repos, but better in all the ways that GitHub is better than GIN as a platform (and likely using Git LFS for any files that are larger than a few MB)
There was a problem hiding this comment.
Can you recombine this with the main deployment again since it doesn't look like anything changed with how they are called?
The suggestion to peel out e2e step was on the lower workflow level, so that 'dev tests' only run vitetest and pytest, and puppeteer calls on pipelines with example data could be a separate npm run call
There was a problem hiding this comment.
Just something to keep in mind if this happens again. Fingers crossed it doesn't though
Replace #902