Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac build #832

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Fix mac build #832

merged 3 commits into from
Jun 5, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Mac build workflow is failing

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 5, 2024
@CodyCBakerPhD
Copy link
Collaborator Author

This PR fixes it: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/workflows/build_and_deploy_mac.yml

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review June 5, 2024 17:40
garrettmflynn
garrettmflynn approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for handling this!

@CodyCBakerPhD CodyCBakerPhD merged commit 47c1331 into main Jun 5, 2024
22 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_mac_build branch June 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmflynn garrettmflynn garrettmflynn approved these changes

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyCBakerPhD @garrettmflynn