-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ci to include windows #99
base: main
Are you sure you want to change the base?
Conversation
Everything is now be building/installing successfully and the tests are running. However, the SWMR mode tests are failing on windows. I'm not sure what exactly might be causing these differences on the windows tests vs. the macOS and ubuntu tests, whether it is an issue with the SWMR mode setup or some other file permission issue. @oruebel do you have any ideas? |
Not sure. Windows tends to lock file access more strongly so maybe the file isn't being closed correctly or opened in non-swmr read mode by the reader. There is a separate read mode for SWMR if I remember correctly. |
@stephprince I synced the PR with the main branch. Just wanted to mention just in case, since there were a number of merge conflicts, but I believe I resolved them all ffffdc5 correctly |
Spoken too soon. But I updated the tests and the build is working now. There is a failure on the tests, but I think that was already happening before the update. |
Fix #15.
These changes add support for windows to our GitHub Actions workflows. As part of these changes, I addressed some build errors and warnings:
CMakeLists.txt
on windows forboost-uuid
functions. In think usually this should be auto-linked, but installingboost
withvcpkg
seems to disable this auto-linking.nwb_file
one) into multiple components to avoid strings being too long for the compiler. I'm not sure how conservative we want to be on the maximum string lengthNote: squash when merging