Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation to Messages filter feature #73

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Conversation

mohamedhesham840
Copy link
Contributor

No description provided.

en/translation.json Outdated Show resolved Hide resolved
Copy link
Contributor

@prix0007 prix0007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor mods required.

en/translation.json Outdated Show resolved Hide resolved
@@ -620,5 +623,7 @@
"eth_gas_price": "ETH gas price",
"strk_gas_price":"STRK gas price",
"eth_gas_price_for_block": "ETH gas price for block",
"strk_gas_price_for_block": "STRK gas price for block"
"strk_gas_price_for_block": "STRK gas price for block",
"l1->l2" : "L1->L2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No special symbols in key, since we want to keep everything snake case only _ are allowed.

@@ -357,6 +357,9 @@
"block_details": "Detalles del bloque",
"unable_locate_transaction_block": "No se pueden ubicar transacciones para el bloque",
"this_block_no_selected": "Este bloque no tiene transacciones del tipo seleccionado",
"this_transaction_no_selected_messages" : "Esta transacción no tiene mensajes del tipo seleccionado",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also needs update.

@@ -349,6 +349,9 @@
"block_details": "Détails du bloc",
"unable_locate_transaction_block": "Impossible de localiser les transactions pour le bloc",
"this_block_no_selected": "Ce bloc n'a pas de transactions du type sélectionné",
"this_transaction_no_selected_messages" : "Cette transaction n'a aucun message du type sélectionné",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also

@@ -620,5 +623,7 @@
"eth_gas_price": "ETH gas price",
"strk_gas_price":"STRK gas price",
"eth_gas_price_for_block": "ETH gas price for block",
"strk_gas_price_for_block": "STRK gas price for block"
"strk_gas_price_for_block": "STRK gas price for block",
"l1->l2" : "L1->L2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Copy link
Contributor

@prix0007 prix0007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@mohamedhesham840 mohamedhesham840 merged commit b280539 into main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants