Remove snapshot; bypass downloading if available locally #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
force-pushed
the
remove-snapshot-for-snapsync
branch
from
dd9ce79
to
642f080
Compare
flcl42
force-pushed
the
remove-snapshot-for-snapsync
branch
from
6d54bb4
to
1df9198
Compare
benaadams
approved these changes
Oct 8, 2024
jmederosalvarado
approved these changes
Oct 9, 2024
LukaszRozmej
reviewed
Oct 9, 2024
| @@ -71,44 +71,53 @@ private async Task InitDbFromSnapshot(CancellationToken cancellationToken) | |||
|
|
|||
| Directory.CreateDirectory(snapshotConfig.SnapshotDirectory); | |||
|
|
|||
| if (GetCheckpoint(snapshotConfig) < Stage.Downloaded) | |||
| if (!File.Exists(snapshotUrl)) | |||
There was a problem hiding this comment.
Url and file? Did you mean snapshotFileName? Would be good to abstract file manipulation to some methods instead of dign it directly.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?