Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing BigFloat keys in WeakKeyIdDict #1829

Merged

Conversation

fingolfin
Copy link
Member

This fails with Julia nightly (as it made BigFloat immutable) and we don't really need this as a feature either.

Resolves #1825

This fails with Julia nightly (as it made BigFloat immutable)
and we don't really need this as a feature either.
@fingolfin fingolfin enabled auto-merge (squash) October 4, 2024 10:29
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (3fe0405) to head (1db2cff).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1829   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         119      119           
  Lines       29988    29982    -6     
=======================================
- Hits        26399    26396    -3     
+ Misses       3589     3586    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin merged commit f1539ec into Nemocas:master Oct 4, 2024
30 checks passed
@fingolfin fingolfin deleted the mh/rm-bigfloat-WeakKeyIdDict-test branch October 4, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly CI failures due to finalizers on BigFloats
2 participants