Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure other packages which only load Rings-conformance-tests.jl
get them.
Finally cleanup how we include Groups-conformance-tests.jl
Unfortunately this causes test failures and eventually a bus error crash (!). This is due to the
test_elem(Rx::AbstractAlgebra.SeriesRing)
method. The crash can be triggered withNote that there are failures before that because the tests for the unsafe ops
add!
etc. don't take into account that the series rings are inexact. I hope #1816 will fix that part.But even taking that into account, we really shouldn't get a hard crash here