Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic test_elem methods #1827

Merged
merged 2 commits into from
Oct 7, 2024
Merged

More generic test_elem methods #1827

merged 2 commits into from
Oct 7, 2024

Conversation

fingolfin
Copy link
Member

Also make sure other packages which only load Rings-conformance-tests.jl
get them.

Finally cleanup how we include Groups-conformance-tests.jl

Unfortunately this causes test failures and eventually a bus error crash (!). This is due to the test_elem(Rx::AbstractAlgebra.SeriesRing) method. The crash can be triggered with

R, x = power_series_ring(ZZ, 10, :x)
include("test/Rings-conformance-tests.jl");
test_Ring_interface(R)

Note that there are failures before that because the tests for the unsafe ops add! etc. don't take into account that the series rings are inexact. I hope #1816 will fix that part.

But even taking that into account, we really shouldn't get a hard crash here

@fingolfin
Copy link
Member Author

@joschmitt figured out the cause for the crash (to be fixed by PR #1828), which in turn was triggered by the coefficients lists for the series starting with a zero.

The failures in the unsafe ops tests are still there, though.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (cb24b07) to head (75c02b4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
+ Coverage   88.12%   88.13%   +0.01%     
==========================================
  Files         119      119              
  Lines       29980    29980              
==========================================
+ Hits        26421    26424       +3     
+ Misses       3559     3556       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member Author

This seems to be ready now.

Also make sure other packages which only load Rings-conformance-tests.jl
get them.

Finally cleanup how we include Groups-conformance-tests.jl
@fingolfin fingolfin enabled auto-merge (squash) October 7, 2024 09:13
@fingolfin fingolfin merged commit 76c7d35 into master Oct 7, 2024
29 of 30 checks passed
@fingolfin fingolfin deleted the mh/test_elem branch October 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants