Extend ideal interface #1731
Merged
Extend ideal interface #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
+ Coverage 87.65% 87.84% +0.18%
==========================================
Files 117 117
Lines 30090 30753 +663
==========================================
+ Hits 26376 27015 +639
- Misses 3714 3738 +24 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Jun 18, 2024
Co-authored-by: Max Horn <[email protected]>
Before, it might have happened that the command `R * ZZRingElem(2)` fails while `R * big(2)` succeeds.
fingolfin
reviewed
Jun 19, 2024
fingolfin
reviewed
Jun 19, 2024
fingolfin
reviewed
Jun 19, 2024
Max: "the advantage is that if some ring type wants to implement say ideal(R::MyRing, n::Int) in a special optimized fashion that avoids constructing R(n), then R*2 would benefit from that" Co-authored-by: Max Horn <[email protected]>
|
BTW we could perhaps add some basic tests by defining, say and then we can do some tests... except we can't do much with it, see issue #1734 |
fingolfin
approved these changes
Jun 19, 2024
fingolfin
reviewed
Jun 24, 2024
Previously, there was a possibility of an infinite recursion if the base functions were not implemented. Also, writing `R(x)` when `x` is a vector is problematic, it might have unexpected results.
fingolfin
reviewed
Aug 1, 2024
This is already allowed for Hecke ideals. For consistency, we allow this already in AbstractAlgebra.
auto-merge was automatically disabled
August 1, 2024 18:47
Head branch was pushed to by a user without write access
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the ideal interface in AbstractAlgebra instead of in OSCAR. This should fix the inconsistencies brought up in oscar-system/Oscar.jl#3826 (comment)
After this pull request is merged, several
idealfunctions can be deleted in OSCAR.