[auth][android] resolve signOut return undefined #174

[kefahB]

Hi @NathanWalker @triniwiz

this is a PR in case you agree about #174.

[kefahB]

@NathanWalker
This is a little issue with logout can you verify and if ok push please.

Thanks

[mukaschultze]

The native signOut return type on android is void, adding async in front of it won't cast it to boolean. I think the best solution would be to add a return true after calling the native method.

[kefahB]

Currently it is return true but it doesn’t work

[kefahB]

So we can register the plugin him self and resolve the promise!
according to the docs signOut has a completion handler.

[kefahB]

@mukaschultze I updated the code since android return void in order to capture the real signOut event.

@NathanWalker @triniwiz What do you think about this way ?

async signOut(): Promise<boolean> {
    return new Promise((resolve, reject) => {
        this.native?.signOut();
        let timeout = setTimeout(() => {
            reject(false);
        }, 3000);
        this.addAuthStateChangeListener((user) => {
            clearTimeout(timeout);
            console.log("User signed out", user);
            if(user) {
                reject(false);
            }
            resolve(true);
        });
     })
}

[kefahB]

@NathanWalker, @triniwiz .. any news aboutt this PR !

[triniwiz]

Sorry didn’t get time to review it but I’ll get to it soon Sent from Yahoo Mail for iPhone On Wednesday, March 8, 2023, 8:29 PM, kefahB ***@***.***> wrote: @NathanWalker, @triniwiz .. any news aboutt this PR ! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>