Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure testing pipeline #6

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Configure testing pipeline #6

merged 2 commits into from
Jan 29, 2024

Conversation

ttuovinen
Copy link
Contributor

@ttuovinen ttuovinen commented Jan 19, 2024 •
edited
Loading

Configure testing pipeline

  • E-kirjasto tests are part of the api test sets
  • Bump up Python versions and remove old versions from test matrix (which is also done in upstream's next version)
  • Temporarily disable Docker builds and pushes
    • Bring them back in a separate pull request. The current setup has issues with the GitHub container registry authentication, probably since our repository is private.
  • Disable Codecov (at least for now) since we don't have an account set up

Misc

  • Remove admin UI build from Docker setup and switch to using ekirjasto-circulation-admin NPM package
  • Fix couple of old merge bugs in api/controller.py
  • Add some null checks to opensearch_analytics_provider.py

@ttuovinen ttuovinen marked this pull request as draft January 19, 2024 08:04
@mikko-work
Copy link
Contributor

Should the tests be succeeding? Latest test seems to be failing.

mikko-work
mikko-work suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@mikko-work mikko-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, they should probably succeed before approving merge?

@ttuovinen
Copy link
Contributor Author

Tests are failing, they should probably succeed before approving merge?

Yes, most definitely. The failing tests relate to the circulation admin package and this PR remains in draft stage until that.

@ttuovinen
Configure testing pipeline (and remove admin ui build)
2ceeeb4 
- Temporarily disable docker builds and pushes
- Disable Codecov (at least for now)
- Switch to ekirjasto-circulation-admin package
- and revert to The Palace Project's circ-baseimage for now
@ttuovinen
Edit tests, add null checks and fix merge bugs
3217e3f
@ttuovinen ttuovinen marked this pull request as ready for review January 24, 2024 13:37
@ttuovinen ttuovinen merged commit b821e65 into main Jan 29, 2024
13 checks passed
@ttuovinen ttuovinen deleted the configure-pipeline branch January 29, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikko-work mikko-work mikko-work approved these changes

@Kaappihullu Kaappihullu Awaiting requested review from Kaappihullu

@attemoi attemoi Awaiting requested review from attemoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttuovinen @mikko-work