-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align driver symlinks with libnvidia-container #715
Conversation
e83c3cf
to
3ef8b44
Compare
pkg/nvcdi/driver-nvml.go
Outdated
for _, mount := range mounts { | ||
dir, filename := filepath.Split(mount.Path) | ||
// TODO: We should include the other libraries as is done here: | ||
// https://github.com/NVIDIA/nvidia-container-toolkit/blob/79c59aeb7f59dd612793ac80a8d7022c554634bb/internal/platform-support/tegra/symlinks.go#L84-L97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code you linked for tegra creates libcuda.so -> libcuda.so.1
while the code below seems to be creating libcuda.so -> libcuda.so.RM_VERSION
. Why the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I was trying to simplify things by linking to the .RM_VERSION
, but since we have the following the driver manifest:
libcuda.so.550.120 0755 CUDA_LIB NATIVE / MODULE:gpgpu
libcuda.so.1 0000 CUDA_SYMLINK NATIVE / libcuda.so.550.120 MODULE:gpgpu
libcuda.so 0000 CUDA_SYMLINK NATIVE / libcuda.so.1 MODULE:gpgpu
we should link to libcuda.so.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the smylink should be to libcuda.so.1
not the actual .RM_VERSION
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in latest.
3ef8b44
to
ee53ed4
Compare
There are other libraries that we create these one-off symlinks for in libnvidia-container. Should we also add these as part of this PR? |
Yes. This was the intent of the comment above the link. I think doing it now makes sense and will update. |
This change aligns the creation of symlinks under CDI with the implementation in libnvidia-container. If the driver libraries are present, the following symlinks are created: * {{ .LibRoot }}/libcuda.so -> libcuda.so.1 * {{ .LibRoot }}/libnvidia-opticalflow.so -> libnvidia-opticalflow.so.1 * {{ .LibRoot }}/libGLX_indirect.so.0 -> libGLX_nvidia.so.{{ .Version }} Signed-off-by: Evan Lezar <[email protected]>
ee53ed4
to
82ae2e6
Compare
Backport PR created as #724 |
This change aligns the creation of symlinks under CDI with
the implementation in libnvidia-container. If the driver libraries
are present, the following symlinks are created: