Use D3DKMTEnumAdapters3 for adapter enumeration #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Thanks @jbujak. I think the mechanics look good. I have one question on the filter applied for the EnumAdapters3 implementation.
Also, is favouring the EnumAdapters3 what we want -- under which conditions should this function not be used?
D3DKMTEnumAdapters3 is required to enumerate MCDM compute-only adapters Signed-off-by: Jakub Bujak <[email protected]>
elezar
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks @jbujak!
Could you add the same comment to NVIDIA/libnvidia-container#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3DKMTEnumAdapters3 is required to enumerate MCDM compute-only adapters