Fix two errors reported by golangci-lint (#23)

NVIDIA · May 10, 2024 · d023c44 · d023c44
2 parents cc2121e + df78411
commit d023c44
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -55,6 +55,7 @@ func New(data []byte) (*TaskConfig, error) {
 
 // NewFromFile populates test config from YAML file
 func NewFromFile(path string) (*TaskConfig, error) {
+	path = filepath.Clean(path)
 	data, err := os.ReadFile(path)
 	if err != nil {
 		return nil, err

diff --git a/pkg/utils/k8s_config_test.go b/pkg/utils/k8s_config_test.go
@@ -110,11 +110,11 @@ func TestGetK8sConfig(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			os.Unsetenv("KUBECONFIG")
+			_ = os.Unsetenv("KUBECONFIG")
 			if len(tc.envCfg) != 0 {
 				f, err := os.CreateTemp("", "test")
 				require.NoError(t, err)
-				defer os.Remove(f.Name())
+				defer func() { _ = os.Remove(f.Name()) }()
 
 				_, err = f.Write([]byte(tc.envCfg))
 				require.NoError(t, err)
@@ -127,7 +127,7 @@ func TestGetK8sConfig(t *testing.T) {
 			if len(tc.kubeCfg) != 0 {
 				f, err := os.CreateTemp("", "test")
 				require.NoError(t, err)
-				defer os.Remove(f.Name())
+				defer func() { _ = os.Remove(f.Name()) }()
 
 				_, err = f.Write([]byte(tc.kubeCfg))
 				require.NoError(t, err)