Skip to content

Commit

Permalink
Disable secure cookies in Kubeflow
Browse files Browse the repository at this point in the history
  • Loading branch information
supertetelman committed Jul 11, 2023
1 parent ed46256 commit 1eb7877
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions scripts/k8s/deploy_kubeflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ function clone_repo() {
# XXX: Change the default Istio Ingress Gateway configuration to support NodePort for ease-of-use in on-prem
sed -i 's:ClusterIP:NodePort:g' "${KUBEFLOW_MANIFESTS_DEST}/common/istio-1-16/istio-install/base/patches/service.yaml"

# XXX: Make the Kubeflow cluster allow insecure http instead of https
# Remove this for any production cluster and enable HTTPS suitable for the environment
# XXX: https://github.com/kubeflow/manifests#connect-to-your-kubeflow-cluster
sed -i 's:JWA_APP_SECURE_COOKIES=true:JWA_APP_SECURE_COOKIES=false:' "${KUBEFLOW_MANIFESTS_DEST}/apps/jupyter/jupyter-web-app/upstream/base/params.env"
sed -i 's:VWA_APP_SECURE_COOKIES=true:VWA_APP_SECURE_COOKIES=false:' "${KUBEFLOW_MANIFESTS_DEST}/apps/volumes-web-app/upstream/base/params.env"
sed -i 's:TWA_APP_SECURE_COOKIES=true:TWA_APP_SECURE_COOKIES=false:' "${KUBEFLOW_MANIFESTS_DEST}/apps/tensorboard/tensorboards-web-app/upstream/base/params.env"

popd
echo "Kubeflow manifests repo:"
echo "- Cloned from: ${KUBEFLOW_MANIFESTS_URL}"
Expand Down

0 comments on commit 1eb7877

Please sign in to comment.