Disable system header for common_type

There is an incredible compiler bug reported in nvbug4867473 where the use of system header changes the way some types are instantiated. Work around it by not marking common_type.h as system header.
NVIDIA · Sep 26, 2024 · 24f0e5b · 24f0e5b
1 parent cc01ce7
commit 24f0e5b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/libcudacxx/include/cuda/std/__type_traits/common_type.h b/libcudacxx/include/cuda/std/__type_traits/common_type.h
@@ -12,13 +12,14 @@
 
 #include <cuda/std/detail/__config>
 
-#if defined(_CCCL_IMPLICIT_SYSTEM_HEADER_GCC)
-#  pragma GCC system_header
-#elif defined(_CCCL_IMPLICIT_SYSTEM_HEADER_CLANG)
-#  pragma clang system_header
-#elif defined(_CCCL_IMPLICIT_SYSTEM_HEADER_MSVC)
-#  pragma system_header
-#endif // no system header
+// We cannot use system header here because of nvbug4867473
+// #if defined(_CCCL_IMPLICIT_SYSTEM_HEADER_GCC)
+// #  pragma GCC system_header
+// #elif defined(_CCCL_IMPLICIT_SYSTEM_HEADER_CLANG)
+// #  pragma clang system_header
+// #elif defined(_CCCL_IMPLICIT_SYSTEM_HEADER_MSVC)
+// #  pragma system_header
+// #endif // no system header
 
 #include <cuda/std/__type_traits/decay.h>
 #include <cuda/std/__type_traits/is_same.h>

diff --git a/...est/libcudacxx/std/numerics/complex.number/complex.special/double_float_explicit.pass.cpp b/...est/libcudacxx/std/numerics/complex.number/complex.special/double_float_explicit.pass.cpp
@@ -15,6 +15,8 @@
 //     constexpr complex(const complex<float>&);
 // };
 
+#undef _CCCL_NO_SYSTEM_HEADER
+
 #include <cuda/std/cassert>
 #include <cuda/std/complex>
 

diff --git a/...est/libcudacxx/std/numerics/complex.number/complex.special/float_double_explicit.pass.cpp b/...est/libcudacxx/std/numerics/complex.number/complex.special/float_double_explicit.pass.cpp
@@ -15,6 +15,8 @@
 //     explicit constexpr complex(const complex<double>&);
 // };
 
+#undef _CCCL_NO_SYSTEM_HEADER
+
 #include <cuda/std/cassert>
 #include <cuda/std/complex>