Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making input- and output-block lazy to allow for nesting #1184

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Making input- and output-block lazy to allow for nesting #1184

merged 6 commits into from
Jul 6, 2023

Conversation

marcromeyn
Copy link
Contributor

Goals ⚽

This PR adds support for nesting TabularInputBlocks which gives more flexibility. Example:

input_block = mm.TabularInputBlock(schema)
input_block.add_route(
    lambda schema: schema,
    mm.TabularInputBlock(init="defaults"),
)

@marcromeyn marcromeyn added enhancement New feature or request area/pytorch labels Jul 5, 2023
@marcromeyn marcromeyn self-assigned this Jul 5, 2023
@marcromeyn marcromeyn requested a review from sararb July 5, 2023 15:46
@marcromeyn marcromeyn marked this pull request as ready for review July 5, 2023 15:50
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1184

@marcromeyn marcromeyn requested a review from edknv July 6, 2023 08:15
@edknv edknv merged commit 58ce8c1 into main Jul 6, 2023
35 checks passed
@edknv edknv deleted the torch/lazy-input-block branch July 6, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

@sararb sararb Awaiting requested review from sararb

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch enhancement New feature or request status/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @edknv