Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ToTuple function #1182

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Adding ToTuple function #1182

merged 3 commits into from
Jul 5, 2023

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Jul 5, 2023 •
edited
Loading

Goals ⚽

This PR adds a convenience function ToTuple, this selects the right ToTupleModule based on the length of the schema that's passed in.

@marcromeyn marcromeyn changed the title Adding ToTuple function that uses the length of the schema to get the… Adding ToTuple function Jul 5, 2023
@marcromeyn marcromeyn self-assigned this Jul 5, 2023
@marcromeyn marcromeyn added enhancement New feature or request area/pytorch labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1182

@marcromeyn marcromeyn marked this pull request as ready for review July 5, 2023 08:41
@marcromeyn marcromeyn merged commit afc1149 into main Jul 5, 2023
35 checks passed
@marcromeyn marcromeyn deleted the torch/to-tuple-fn branch July 5, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @oliverholworthy