Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Schema Inspection names in the torch schema module #1179

Merged

Conversation

oliverholworthy
Copy link
Member

Goals ⚽

Add schema inspection functions to top-level merlin.models.torch module.

  • input_schema - schema describing the inputs expected by the module
  • output_schema - schema describing the outputs of the module
  • feature_schema - schema describing the expected features passed to the module during training
  • target_schema - schema describing the expected targets passed to the module during training

Implementation Details 🚧

Renames schema.input to schema.input_schema, and schema.output to schema.output_schema

Testing Details 🔍

Exisitng tests updated to reflect new names

@oliverholworthy oliverholworthy added the enhancement New feature or request label Jul 4, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jul 4, 2023
@oliverholworthy oliverholworthy self-assigned this Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1179

@oliverholworthy oliverholworthy merged commit eddc2ab into NVIDIA-Merlin:main Jul 5, 2023
35 checks passed
@oliverholworthy oliverholworthy deleted the torch-schema-functions branch July 5, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants