Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ToTuple #1178

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Adding ToTuple #1178

merged 3 commits into from
Jul 4, 2023

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Jul 4, 2023 •
edited
Loading

Goals ⚽

Triton doesn't support models that output a dictionary. This PR introduces modules to convert a dict to a tuple, this can be used inside the save_for_triton function that will be added soon.

@marcromeyn marcromeyn self-assigned this Jul 4, 2023
@marcromeyn marcromeyn added enhancement New feature or request area/pytorch labels Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1178

@marcromeyn marcromeyn marked this pull request as ready for review July 4, 2023 16:53
@marcromeyn marcromeyn merged commit 0b1c198 into main Jul 4, 2023
35 checks passed
@marcromeyn marcromeyn deleted the torch/dict-to-tuple branch July 4, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @oliverholworthy