We need to remove README after the hyper link. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
Documentation preview |
oliverholworthy
approved these changes
Jun 30, 2023
|
@oliverholworthy @marcromeyn thank you for approving this pull request. I needed to add a label for this (maybe label=documentation). I cannot add labels as I cannot find any. I may need to convert this to a draft first, and add the label (please see the attachment). Is that a right approach to do so? Thank you.
|
oliverholworthy
added
the
documentation
|
@tien-nguyen thanks for opening this PR to fix the link, labels can only be added by maintainers currently. I applied the documentation label and merged the change. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Goals ⚽
Remove the README in the hyperlink as if we have it there, it is not correct.
Implementation Details 🚧
I remove the README in the hyperlink.
Testing Details 🔍
I tested on the web URL: https://nvidia-merlin.github.io/models/stable/examples/ , this is the correct link.