Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forestall pandas 2.0 errors by making pandas < 2.0 in setup.py. #484

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

cdeline
Copy link
Contributor

@cdeline cdeline commented Nov 8, 2023

As stated in #449, we haven't quite fixed Pandas 2.0 errors yet. This is now breaking tests in --upgrade-strategy-eager test profiles. Until we fix it, require Pandas < 2.0 in setup.py

@cdeline cdeline self-assigned this Nov 8, 2023
@cdeline cdeline marked this pull request as draft November 8, 2023 23:54
@cdeline cdeline marked this pull request as ready for review November 8, 2023 23:56
@cdeline
Copy link
Contributor Author

cdeline commented Nov 9, 2023

The docker test is still failing on Main (but works on Development for some reason?) This is outside my area of expertise - hopefully we can fix this in a later PR.

@cdeline
Copy link
Contributor Author

cdeline commented Nov 9, 2023

Merging this for now while we work on other Pandas 2.0 fixes.

@cdeline cdeline merged commit 7dba9b2 into NREL:main Nov 9, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant