Skip to content

Commit

Permalink
Update todo items
Browse files Browse the repository at this point in the history
  • Loading branch information
cdeline committed Nov 27, 2023
1 parent 4ce1a54 commit fd15425
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions bifacial_radiance/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2492,7 +2492,8 @@ def makeScene(self, module=None, sceneDict=None, radname=None,
sceneRAD = scene._makeSceneNxR(sceneDict=sceneDict,
radname=radname)

# TODO: move appendRadfile logic to SceneObj...
# TODO: deprecate this section in favor of multiple sceneObjs
#
if 'appendRadfile' not in sceneDict:
appendRadfile = False
else:
Expand All @@ -2513,10 +2514,12 @@ def makeScene(self, module=None, sceneDict=None, radname=None,
print( "Radfile APPENDAGE created!")
else:
scene.radfiles = [sceneRAD]

#TODO: change appendtoScene kwarg to customObject kwarg. keep appendtoScene as deprecated input
if appendtoScene is not None:
self.appendtoScene(scene.radfiles[0], customObject = appendtoScene)

# TODO: what's the desired default behavior here?
# Do we append a new scene by default, or overwrite?
self.scenes.append(scene)
return scene

Expand Down

0 comments on commit fd15425

Please sign in to comment.