Convert site electricity sensor from Joules to watts #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TShapinsky
commented
Feb 6, 2024
| @@ -28,6 +28,7 @@ def get_idd_type(object) | |||
| # @return [String] | |||
| def create_ems_str(id) | |||
| id = id.gsub(/[\s-]/, '_') | |||
| id = id.gsub(/[^\w]/, '_') | |||
There was a problem hiding this comment.
Without this the function is not idempotent. It will prepend _ forever
|
@kbenne we had paused on merging this to consider whether the conversion should be handled in E+ instead. Since the next Alfalfa release will remove MLEP, we aren't worried about lasting consequences. |
TShapinsky
force-pushed
the
adjust_site_sensors
branch
from
e587b19
to
c44052e
Compare
TShapinsky
force-pushed
the
adjust_site_sensors
branch
from
c44052e
to
fa89987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a program to divide site electricity sensor by 60 to convert it from Joules to Watts (Joules/Second).