Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More ruby documentation #1762

Merged
merged 7 commits into from
Jun 27, 2024
Merged

More ruby documentation #1762

merged 7 commits into from
Jun 27, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jun 27, 2024 •
edited
Loading

Pull Request Description

Addresses #1759.

  • hpxml_defaults.rb
  • version.rb
  • xmlvalidator.rb

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Jun 27, 2024
@shorowit shorowit marked this pull request as ready for review June 27, 2024 22:50
@shorowit shorowit merged commit dd977d6 into master Jun 27, 2024
7 checks passed
@shorowit shorowit deleted the more-ruby-docs branch June 27, 2024 23:18
@joseph-robertson joseph-robertson mentioned this pull request Jul 11, 2024
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
None yet
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit