generated from NOW-SOPT-ANDROID/now-sopt-android-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
week7: 7차 필수과제 진행 (xml) #19
Open
junseo511
wants to merge
5
commits into
develop-xml
Choose a base branch
from
feat/week_xml7
base: develop-xml
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
app/src/main/java/com/sopt/now/data/remote/di/UrlModule.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.sopt.now.data.remote.di | ||
|
||
import com.sopt.now.BuildConfig | ||
import dagger.Module | ||
import dagger.Provides | ||
import dagger.hilt.InstallIn | ||
import dagger.hilt.components.SingletonComponent | ||
import javax.inject.Qualifier | ||
|
||
@Module | ||
@InstallIn(SingletonComponent::class) | ||
object UrlModule { | ||
@AuthBaseUrl | ||
@Provides | ||
fun provideAuthBaseUrl(): String = BuildConfig.AUTH_BASE_URL | ||
|
||
@FriendBaseUrl | ||
@Provides | ||
fun provideFriendBaseUrl(): String = BuildConfig.FRIEND_BASE_URL | ||
} | ||
|
||
@Retention(AnnotationRetention.BINARY) | ||
@Qualifier | ||
annotation class AuthBaseUrl | ||
|
||
@Retention(AnnotationRetention.BINARY) | ||
@Qualifier | ||
annotation class FriendBaseUrl |
25 changes: 25 additions & 0 deletions
25
app/src/main/java/com/sopt/now/data/remote/repository/AuthRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package com.sopt.now.data.remote.repository | ||
|
||
import com.sopt.now.data.remote.request.SignInRequest | ||
import com.sopt.now.data.remote.request.SignUpRequest | ||
import com.sopt.now.data.remote.response.SignInResponse | ||
import com.sopt.now.data.remote.response.SignUpResponse | ||
import com.sopt.now.data.remote.service.AuthService | ||
import retrofit2.Response | ||
import javax.inject.Inject | ||
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class AuthRepository | ||
@Inject | ||
constructor( | ||
private val authService: AuthService, | ||
) { | ||
suspend fun signUp(request: SignUpRequest): Response<SignUpResponse> { | ||
return authService.signUp(request) | ||
} | ||
|
||
suspend fun signIn(request: SignInRequest): Response<SignInResponse> { | ||
return authService.signIn(request) | ||
} | ||
} |
18 changes: 18 additions & 0 deletions
18
app/src/main/java/com/sopt/now/data/remote/repository/FriendRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.sopt.now.data.remote.repository | ||
|
||
import com.sopt.now.data.remote.response.FriendsResponse | ||
import com.sopt.now.data.remote.service.FriendService | ||
import retrofit2.Response | ||
import javax.inject.Inject | ||
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class FriendRepository | ||
@Inject | ||
constructor( | ||
private val friendService: FriendService, | ||
) { | ||
suspend fun getFriends(page: Int): Response<FriendsResponse> { | ||
return friendService.getFriends(page) | ||
} | ||
} |
27 changes: 27 additions & 0 deletions
27
app/src/main/java/com/sopt/now/data/remote/repository/UserRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package com.sopt.now.data.remote.repository | ||
|
||
import com.sopt.now.data.remote.request.ChangePasswordRequest | ||
import com.sopt.now.data.remote.response.ChangePasswordResponse | ||
import com.sopt.now.data.remote.response.UserResponse | ||
import com.sopt.now.data.remote.service.UserService | ||
import retrofit2.Response | ||
import javax.inject.Inject | ||
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class UserRepository | ||
@Inject | ||
constructor( | ||
private val userService: UserService, | ||
) { | ||
suspend fun getUserInfo(userId: Int): Response<UserResponse> { | ||
return userService.getUserInfo(userId) | ||
} | ||
|
||
suspend fun changePassword( | ||
userId: Int, | ||
request: ChangePasswordRequest, | ||
): Response<ChangePasswordResponse> { | ||
return userService.changePassword(userId, request) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...w/data/remote/response/GetUserResponse.kt → .../now/data/remote/response/UserResponse.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 0 additions & 11 deletions
11
app/src/main/java/com/sopt/now/ui/common/base/BaseFactory.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[2]
레포지토리 패턴은 데이터 소스를 추상화하는데 의미가 있습니다.
즉 뷰단에서는 이 값들이 우리 서버에서 왔는지, 로컬 디비에서 왔는지 혹은 파이어베이스에서 왔는지 관심이 없다는 뜻이죠.
그런 레포지토리가 레트로핏의 Response 형태로 값을 반환하게 된다면 네트워크 통신의 결과물이라는 의미를 내포하게 됩니다.
그러므로 Response로 래핑된 형태가 아닌 ResponseSignUpDto의 형태로 반환해보는 것은 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 무슨 뜻인지 알겠습니다 ㅋㅋㅋㅋ!! 감사합니다 앱잼 준비하다보니 답변이 늦었네요 ㅠㅠ
파이팅해보겠습니다 :) 용민님도 항상 건승하시길...!