Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Fix heal_bridges_osm.py warning #1225

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Conversation

ZahraGhahremani
Copy link
Contributor

@ZahraGhahremani ZahraGhahremani commented Jul 18, 2024

This PR fixes issue #1221. With this the empty DataFrame will not save.

Changes

  • heal_bridges_osm.py

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • N/A New functions are documented (with a description, list of inputs, and expected output)
  • N/A Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

ZahraGhahremani-NOAA and others added 2 commits July 18, 2024 23:50
@ZahraGhahremani ZahraGhahremani changed the title Fix heal_bridges_osm.py warning [1pt] PR: Fix heal_bridges_osm.py warning Jul 19, 2024
@ZahraGhahremani ZahraGhahremani self-assigned this Jul 19, 2024
@ZahraGhahremani ZahraGhahremani marked this pull request as ready for review July 19, 2024 19:33
@RobHanna-NOAA
Copy link
Contributor

@ZahraGhahremani : go ahead and merge latest dev into this, then we can likely get Matt or someone else to approve if Carson can't do it before Thurs. That way we can get it in for the merge early next week. :)

ZahraGhahremani-NOAA added 3 commits July 24, 2024 04:25
Merge remote-tracking branch 'origin/dev' into dev-heal-bridges
Merge remote-tracking branch 'origin/dev' into dev-heal-bridges
Merge remote-tracking branch 'origin/dev' into dev-heal-bridges
@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit b282955 into dev Aug 16, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-heal-bridges branch August 16, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Warning when heal_bridges_osm.py tries to save an empty DataFrame
3 participants