-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Catchment Boundary Tool Addition #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the tools/inundate_catchment_boundary.py script for several HUCs (02030105, 21010005, 15020001, and 01060001). Each run took approximately 2 to 3 minutes, and the results successfully identified the intersection between the raster extent and the catchment boundary.
However, I suggest adding an attribute to the boundary lines to indicate whether a segment applies to branch 0, the GMS branch, or both (As Ryan mentioned too). This would help prevent confusion at first glance. For example, in HUC 02030105, there is a boundary line in branch 0 even though there is no intersection between the raster and the catchment. This initially seems confusing but makes sense when examining other branch boundaries.
still being worked on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still wip
Updated code to link catchment boundary lines correct HydroID:
Updated code to identify which branch is causing the error:
Additionally filtered out all error lines less than 100m. |
…y-tool Conflicts: tools/identify_catchment_boundary.py tools/inundate_catchment_boundary.py
This PR adds scripts that can identify areas within produced inundation rasters where glasswalling of inundation occurs due to catchment boundaries, know as catchment boundary issues.
Addresses #1063.
Additions
tools/identify_catchment_boundary.py
: Identifies where catchment boundaries are glasswalling inundation extent.tools/inundate_catchment_boundary.py
: Produces inundation for given HUC and identifies catchment boundary issues in produced FIM.Testing
Screenshots
Examples of HUC 17110010 from #1063:
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally/foss_fim/
, run:pytest unit_tests/
)4.x.x.x
Merge Checklist (For Technical Lead use only)