Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate R script #25

Merged
merged 122 commits into from
Oct 24, 2024
Merged

Automate R script #25

merged 122 commits into from
Oct 24, 2024

Conversation

glitt13
Copy link
Collaborator

@glitt13 glitt13 commented Oct 17, 2024

Automate R script for calling in command line.

Additions

Removals

Changes

Can now call the following in command:

Rscript fs_attrs_grab.R "/path/to/attribute_config.yaml"

Testing

  1. No unit tests for this script because no new functions created.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

glitt13 and others added 30 commits August 22, 2024 09:29
describe the unique dependencies
…fix associated functions when behavior didn't follow expected behavior
…go_train_eval module; feat: move some hard-coded variables into the algorithm config file
@glitt13 glitt13 requested a review from bolotinl October 17, 2024 15:09
@glitt13
Copy link
Collaborator Author

glitt13 commented Oct 17, 2024

@bolotinl , this PR assumes that the code in the fsds_fs is accepted. We will first merge any changes that happen there in case they're needed to keep this branch up-to-date.

bolotinl
bolotinl previously approved these changes Oct 23, 2024
Copy link
Collaborator

@bolotinl bolotinl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few minor typo comments. I thought I had edited these and committed them directly myself, but now I'm not so sure those changes stuck so I added them as comments. Once these are addressed go ahead and merge.

README.md Outdated Show resolved Hide resolved
@glitt13
Copy link
Collaborator Author

glitt13 commented Oct 24, 2024

@bolotinl - resolved aforementioned mis-spellings with the latest commit, but now this needs reapproval.

@glitt13 glitt13 merged commit a51de8d into NOAA-OWP:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants